Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css linting and lint workflow to github action #96

Merged
merged 5 commits into from
Dec 22, 2020

Conversation

YouKnowBlom
Copy link
Contributor

@YouKnowBlom YouKnowBlom commented Dec 13, 2020

Add css linting via stylelint and fix issues in jellyfin.css.
Remove glyphicons.css as it's unused.
Add lint step to github actions.
Remove lint step from Azure CI

@YouKnowBlom
Copy link
Contributor Author

Seems the prettier worked its magic on the azure ci file

@simonmarklar
Copy link

@YouKnowBlom you can turn off whitespace changes in the review to ignore the prettier changes

should the src/fonts/glyphicons-* files be removed as well ?

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow file looks good 👍

@YouKnowBlom
Copy link
Contributor Author

should the src/fonts/glyphicons-* files be removed as well ?

Ah I missed those, good point 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants