-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tvOS] Mirror iOS Ratings + Attribute Settings #1422
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wary of making future settings that increases granularity but am fine that attributes can be customizable. We should investigate some general solution in the future.
For the |
Summary
This mirrors the changes for #1420 in tvOS. Pure Copy + Paste. Shout out to @samglt for doing the hard part and creating a layout that looks native and polished!
This section of tvOS has a lot of remaining horizontal room so luckily I don't think we have to worry about potential spacing issues that might arise in iOS. My only concern in this area is that the ratings are relatively smaller compared to the size of the tv screen so it might be more easily 'lost' for those looking for it. If that doesn't concern us, I think @samglt's design on this looks very polished and at home on tvOS!
In addition to copying over these attributes, I added 2 settings on both iOS and tvOS to turn Critic or Community ratings off. There is a certain amount of chatter online that some people are not fans of seeing ratings of their media so this gives them the ability to turn this off. I split this out in case people want one but not the other.
Outstanding Discussion
This is a small change with only the toggle being new. Do we still want these ratings in the 'About' section of the
ItemView
as well? That 'About' section the description and ratings (now both duplicates from above) and the media info. IMO, I think this section (in another PR) should just be the media info and maybe we break it out a little more? Totally open to discussion, not a part of this PR.Only item for this PR is do we want to remove the ratings down there as well with the toggle? Or, do we want to remove ratings altogether now they're in the attributes?
Screenshots
tvOS New Rating
iOS New Setting