Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvOS] Mirror iOS Ratings + Attribute Settings #1422

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Feb 7, 2025

Summary

This mirrors the changes for #1420 in tvOS. Pure Copy + Paste. Shout out to @samglt for doing the hard part and creating a layout that looks native and polished!

This section of tvOS has a lot of remaining horizontal room so luckily I don't think we have to worry about potential spacing issues that might arise in iOS. My only concern in this area is that the ratings are relatively smaller compared to the size of the tv screen so it might be more easily 'lost' for those looking for it. If that doesn't concern us, I think @samglt's design on this looks very polished and at home on tvOS!

In addition to copying over these attributes, I added 2 settings on both iOS and tvOS to turn Critic or Community ratings off. There is a certain amount of chatter online that some people are not fans of seeing ratings of their media so this gives them the ability to turn this off. I split this out in case people want one but not the other.

Outstanding Discussion

This is a small change with only the toggle being new. Do we still want these ratings in the 'About' section of the ItemView as well? That 'About' section the description and ratings (now both duplicates from above) and the media info. IMO, I think this section (in another PR) should just be the media info and maybe we break it out a little more? Totally open to discussion, not a part of this PR.

Only item for this PR is do we want to remove the ratings down there as well with the toggle? Or, do we want to remove ratings altogether now they're in the attributes?

Screenshots

tvOS New Rating

Simulator Screenshot - Apple TV 4K (3rd generation) - 2025-02-07 at 12 00 29

iOS New Setting

Simulator Screenshot - iPhone 16 Pro - 2025-02-07 at 12 16 09

@JPKribs JPKribs added the enhancement New feature or request label Feb 7, 2025
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wary of making future settings that increases granularity but am fine that attributes can be customizable. We should investigate some general solution in the future.

@LePips
Copy link
Member

LePips commented Feb 7, 2025

For the About section, I don't have an answer right now but think that the entire section could be customizable in the future.

@JPKribs
Copy link
Member Author

JPKribs commented Feb 7, 2025

I am wary of making future settings that increases granularity

Sorry, I feel like I always do this... Do you mean, less settings altogether or a more broad approach? I was tinkering with a more broad approach before I committed this that is simultaneously more granular but also a more general solution:

I've committed this change. Let me know if this direction is the way that you want to go. Personally, I like this level of flexibility but I completely agree that a single, standard implementation beats out granular customization. Getting something functional and easier to maintain should be the priority. I believe this route is our easiest/best way of allowing attribute editing but I'm not sold on needing this.

If we don't like this appreach, I can revert and just commit the Defaults change instead! Let me know!

This is what this looks like on tvOS:

Simulator.Screen.Recording.-.Apple.TV.4K.3rd.generation.-.2025-02-08.at.13.12.35.mp4

Resulting in this:

Screenshot 2025-02-08 at 13 13 11

In this approach, I have a new ItemViewAttributes enum. Very similar to the Filters logic. Instead of a toggle for "Audio 5.1, Audio 7.1..." etc, I have HD/4K and Audio grouped together. This is all stored as 1 [ItemViewAttributes] so it's simultaneously more ability to customize these attributes but it doesn't require that we build out new toggles for each setting.


Example screenshots of what this would look like (iOS)

Settings
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-08.at.12.59.53.mp4
Result Screenshot 2025-02-08 at 13 00 30

@JPKribs JPKribs changed the title [tvOS] Mirror iOS Ratings + Toggle [tvOS] Mirror iOS Ratings + Attribute Settings Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants