Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export dts file typings #789

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Export dts file typings #789

merged 1 commit into from
Nov 5, 2023

Conversation

SferaDev
Copy link
Contributor

@SferaDev SferaDev commented Nov 3, 2023

WHAT

Export types module export.

WHY

To support moduleResolution: bundler

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Linter
  • Tests
  • Review comments
  • Security

Copy link

changeset-bot bot commented Nov 3, 2023

⚠️ No Changeset found

Latest commit: c769e6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-validations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 8:11am
next-validations-demo ❌ Failed (Inspect) Nov 3, 2023 8:11am

Copy link
Contributor

sweep-ai bot commented Nov 3, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link
Owner

@jellydn jellydn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@jellydn
Copy link
Owner

jellydn commented Nov 5, 2023

@all-contributors please add @SferaDev for code.

@jellydn jellydn merged commit 62506ea into jellydn:main Nov 5, 2023
5 checks passed
Copy link
Contributor

@jellydn

I've put up a pull request to add @SferaDev! 🎉

@jellydn
Copy link
Owner

jellydn commented Nov 5, 2023

@all-contributors please add @jellydn for code and doc.

Copy link
Contributor

@jellydn

I've put up a pull request to add @jellydn! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants