Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cache limit #35

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Added cache limit #35

merged 2 commits into from
Oct 13, 2020

Conversation

TwoAbove
Copy link
Contributor

This PR adds a cache limiter.

This is something that we need to keep the cache from growing too large if we have a spike in caching.

@TwoAbove
Copy link
Contributor Author

I'm not sure what's wrong with the CI, though. It seems that It's passing and then returning 1?

@ReneKroon
Copy link
Contributor

Hi there, i will probably merge this later this week.

The CI is fine, however i've included some token for the code coverage. I should only trigger that on my own account i suppose.

@TwoAbove
Copy link
Contributor Author

Thanks @ReneKroon !

@ReneKroon
Copy link
Contributor

One note, the test does'nt check that indeed the last added items are in the cache. Can you fix that? I have no other comments and will merge after checking the build status manually (i'll accept that Travis cannot work with remote MR's at this time and fix that later)

@TwoAbove
Copy link
Contributor Author

@ReneKroon sure, I'll add more tests

@TwoAbove
Copy link
Contributor Author

@ReneKroon Updated the test to assert that only the last 10 are present

@ReneKroon
Copy link
Contributor

merging, will release this week as well.

@ReneKroon ReneKroon closed this Oct 13, 2020
@ReneKroon ReneKroon reopened this Oct 13, 2020
@ReneKroon ReneKroon merged commit 6bf8a2f into jellydator:master Oct 13, 2020
@TwoAbove
Copy link
Contributor Author

@ReneKroon Thank you!

@ReneKroon
Copy link
Contributor

released as v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants