Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkExpireCallback doesn't work when skipTtlExtension is enabled. #15

Closed
sagarkrkv opened this issue Feb 20, 2019 · 1 comment
Closed

checkExpireCallback doesn't work when skipTtlExtension is enabled. #15

sagarkrkv opened this issue Feb 20, 2019 · 1 comment

Comments

@sagarkrkv
Copy link

When checkExpireCallback returns true, we should always extend the ttl of the item, irrespective of the value of skipTtlExtension.
https://github.com/ReneKroon/ttlcache/blob/f76125ae8c0559130e32b4f47bb3284f7abed9a8/cache.go#L89-L93
sagarkrkv pushed a commit to sagarkrkv/ttlcache that referenced this issue Feb 21, 2019
Fix issue jellydator#15
dfeac74
@ReneKroon
Copy link
Contributor

I appreciate the attached test case, since it crashes it's pretty obvious something is wrong .. I agree with your reasoning about extending TTL, so i will merge it.

ReneKroon added a commit that referenced this issue Feb 25, 2019
@ReneKroon
Merge pull request #16 from sagarkrkv/fix-expiration-callback
dcd0e0a 
Fix issue #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ReneKroon @sagarkrkv