Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Mastodon to the social networks #198

Merged
merged 4 commits into from
Feb 14, 2018
Merged

Adding Mastodon to the social networks #198

merged 4 commits into from
Feb 14, 2018

Conversation

Bandie
Copy link
Contributor

@Bandie Bandie commented Feb 5, 2018

With this you can add a Mastodon username+instance to your config which will show it nicely like all the other social services.

@DirtyF DirtyF requested a review from a team February 5, 2018 16:55
@parkr
Copy link
Member

parkr commented Feb 12, 2018

What does this look like when the options are specified? What if a user is on multiple instances?

@Bandie
Copy link
Contributor Author

Bandie commented Feb 12, 2018

It looks like this:

jekyll_mst
You don't see the instance name intentionally because

  1. it would break the design
  2. Mastodon does it the same for known users within a conversation

I assumed that someone would add just one instance.
If you request it to have more than one we'd have to change it.
We could do something like

mastodon_username1: foo1
mastodon_instance1: bar1
mastodon_username2: foo2
...

…if you don't have a better idea.

@parkr
Copy link
Member

parkr commented Feb 12, 2018

@Bandie Thanks for the screenshot! Hard to test when I'm on mobile ☎️ . 😄

As for multiple instances, I see lots of folks using multiple instances so if we're going to support this, I'd love to support multiple instances right off the bat. What do you think about this in the _config.yml file?

mastadon:
- username: parkr
  instance: foo.bar.com

Then in the Liquid, you'd check for site.mastadon in your if, and then for loop over site.mastadon.

@Bandie
Copy link
Contributor Author

Bandie commented Feb 13, 2018

jekyll_mst2
Thanks @parkr, now I know that the html stuff is called Liquid. :D
Here you are~

_config.yml Outdated
# Mastodon instances
# mastodon:
# - username: jekyll
# instance: mastodoninstance.tld
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using example.com here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed™

@parkr
Copy link
Member

parkr commented Feb 14, 2018

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 6baaec2 into jekyll:master Feb 14, 2018
jekyllbot added a commit that referenced this pull request Feb 14, 2018
@jekyllbot jekyllbot mentioned this pull request Mar 10, 2018
@jekyll jekyll locked and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants