Fix encoding error for gist_tag #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,7 +70,7 @@ def fetch_raw_code(gist_id, filename = nil) | |||
| read_timeout: 3, open_timeout: 3) do |http| | |||
| request = Net::HTTP::Get.new uri.to_s | |||
| response = http.request(request) | |||
| response.body | |||
| response.body.force_encoding(@encoding) | |||
There was a problem hiding this comment.
I think GitHub always sends back UTF-8. Maybe @benbalter can help with this?
There was a problem hiding this comment.
Perhaps, but if the Jekyll user sets their site to use something else, and jekyll-gist returns utf-8, is Liquid not going to error out as it is now, with the mix of utf-8 and ascii 8bit?
|
Released in v1.3.5! Thanks :) https://github.com/jekyll/jekyll-gist/releases/tag/v1.3.5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #18 and #22 by ensuring gists are loaded into the same encoding as the site itself