Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewind request.body only when possible #719

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Rewind request.body only when possible #719

merged 1 commit into from
Dec 12, 2024

Conversation

ashmaroli
Copy link
Member

With recent changes to use rackup lib directly, request.body is now Rackup::Handler::WEBrick::Input which does not respond to :rewind method. But our test mocks still do.

@ashmaroli ashmaroli merged commit 32f01ba into master Dec 12, 2024
5 checks passed
@ashmaroli ashmaroli deleted the lazy-rewind-request-body branch December 12, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ashmaroli