Fix for completion display bug with tmux/IntelliJ #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntelliJ terminal requires `zle redisplay` to be called but this breaks completion menus in non IntelliJ terminals. This uses an environment variable to detect whether we are in an IntelliJ terminal and only calls `zle redisplay` for those environments. Previously the code tried to guard against this bug by looking at `$LASTWIDGET` but unfortunately we cannot reliably assume that the completion widget has `complet` in the name (on my personal setup, I saw `autosuggest-suggest` and `self-insert` as the `$LASTWIDGET` during completions depending on context and other zsh plugins enabled). See also: jeffreytse#122
|
I do not use IntelliJ and I would love if someone could validate behavior inside the IntelliJ terminal. I have seen reliably that IntelliJ should be setting this environment variable and I can validate that setting this environment variable reintroduces the bug for non-IntelliJ terminals and removing the environment variable fixes the bug for non-IntelliJ terminals |
|
Hey @jeffreytse , no real urgency but I'm just curious what would be necessary to help move this forward? |
|
Hi @michaelorr Thanks for your contribution to this project, I will try to do a quick review as soon as possible. : ) Thanks & Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntelliJ terminal requires
zle redisplayto be called but this breakscompletion menus in non IntelliJ terminals.
This uses an environment variable to detect whether we are in an
IntelliJ terminal and only calls
zle redisplayfor those environments.See also: https://youtrack.jetbrains.com/issue/IDEA-191464/Add-environment-variable-to-terminal-detect-if-running-in-IntelliJ-IDES
Previously the code tried to guard against this bug by looking at
$LASTWIDGETbut unfortunately we cannot reliably assume that the completion widget
has
completin the name (on my personal setup, I sawautosuggest-suggestandself-insertas the$LASTWIDGETduringcompletions depending on context and other zsh plugins enabled).
See also: #122