-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Adding zsh-vi-mode causes nav keys (Home, End, PgUp and PgDn ) to break #59
Comments
Hi @deafmute1 Thank you for reporting this issue. I will focus on this issue and fix it and welcome to star this project for further updates in the future. Thanks and regards |
This commit fixed some issues about the escape sequences, such as you can not trigger the widget bound on <PgUp> (i.e. `^[[5~`) correctly, you just get an unexpected result.
Hi @deafmute1 Thanks for the patience, this issue has been addressed and fixed, please upadte your plugin to the latest version. And welcome to star this project for further updates in the future. : ) Thanks and regards. |
Hi @deafmute1 Could we close this issue? If you still have other issues, please let me know. : ) Thanks and regards |
Hi, |
Hi @fdietze Could you give me some more instructions on your issue? Such as your Thanks and regards |
I just stripped my source "${HOME}/.zgen/zgen.zsh"
if ! zgen saved; then
echo "creating zgen save..."
zgen load jeffreytse/zsh-vi-mode
zgen save
fi alacritty 0.8.0 |
@fdietze For this, what plugin keybindings on the |
I expected Thank you |
@jeffreytse I'm having the same issue. By default, Manjaro registers the keys as below, which works fine except when I source this plugin. Do I need to set a separate keybinding for this plugin? if so which
|
Thanks for the information, I will try to dig up this issue and fix it as soon as possible. Thanks and regards |
Hi @fdietze For the default vi keybindings (i.e. Thanks and regards |
That's correct, the default zsh vi mode does not map Home/End. But the bash vi mode and vim support it by default. I thought that it would make sense to map these keys by default. Something like:
What do you think? |
Can confirm, also managed to do it like that, my key codes were just different with. Might be nice to have those as default key bindings though |
So sorry for the late following up, I have been busy recently, thanks for your suggestions. I will take a consideration for adding them to default keybindings. Before that you can easily fulfill these keybindings by adding manually with Thanks and regards |
Hi, this issue occurred today after updating all my plugins. I narrowed it down to zsh-vi-mode by turning plugins on/off until reproducing.
Basically: Home, End, PgUp and PgDn emit the incorrect scan codes according to both
terminfo
andshowkey --scancode
after sourcing zsh-vi-mode . Also, multiple keys have the same code - Home and End are both[
, while PgUp and PgDn are both[~
.The text was updated successfully, but these errors were encountered: