Typescript idempotency initial dev branch #1
Conversation
| import { PersistenceLayerInterface } from './PersistenceLayerInterface'; | ||
|
|
||
| abstract class PersistenceLayer implements PersistenceLayerInterface { | ||
| public configure(_config: IdempotencyConfig): void {} |
There was a problem hiding this comment.
I've been distracted so I may have missed the reasoning, but why isn't this the constructor?
There was a problem hiding this comment.
We followed what the Python version had, the persistence layer does have its own constructor defined that saves other things on the constructor. I don't have the constructor here currently because many of those objects are related to config that is outside the scope of what we plan to deliver for the first set of functionality
| import { AnyFunction } from 'types/AnyFunction'; | ||
| import { IdempotencyOptions } from './IdempotencyOptions'; | ||
|
|
||
| const makeFunctionIdempotent = ( |
There was a problem hiding this comment.
Should we make this a type as well that way we can pass the generic from here down. So we makeFunctionIdempotent<U> and the function would return that Type? Or am I missing something? Otherwise isnt the generic not propagated?
…ithub.com/jeffrey-baker-vg/aws-lambda-powertools-typescript into typescript-idempotency-initial-dev-branch
Description of your changes
How to verify this change
Related issues, RFCs
Issue number:
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.