JSON.stringify() container cradle results in memory leak because of cyclic references #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winston, sentry, and many more libraries, which call internally
JSON.stringify
or some other (custom) function for JSON serialization, cause a memory leak when passed a container cradle.I especially had the case together with Sequelize and winston json formatter. For some reason, sometimes (mostly in case of errors) it tried to log the whole container cradle. This took forever and resulted in a silent app crash which was not immediately traced back to the problems roots.
This PR simply checks if the container cradle was called via
JSON.stringify
by checking fortoJSON
and returns a simple string.Following github issues are connected to this:
coopernurse/node-pool#275
sequelize/sequelize#10443
Thanks!