Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code to utilize the new ForwardDiff. I had trouble locally aligning the versions of Celeste's dependencies, so I'm relying on Travis to tell me whether or not this PR works.
I'm using WIP tag for this PR because I was a bit confused by the
convert
methods intest/derivative_utils.jl
. They break the semantic interface ofBase.convert
, i.e. these convert methods do not obeyconvert(T, x)::T)
. It seems like their purpose is to mapElboArgs{T}
toElboArgs{GradientNumber{N,T}}
orElboArgs{HessianNumber{N,T}}
, but I'm not sure where/how this is getting used.I technically could do a naive rewrite of these methods using
ForwardDiff
's newDual
type, but as I was unsure, I chose to comment them out and see what happens.