-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin throws Error in >=1.0.2 #5
Comments
My CI works fine on Node 5.4.0. It seems the version of Node might have something to do with it? I'm guessing you're stuck on Node 4.2 for a while? |
4.2 is still the LTS version, so we'll probably be on that for a while. We can just use 1.0.0, it's not an issue. I just thought you should know! |
@danieldiekmeier I've added Node 4.2 and 5.5 to PR #6 and it looks like they are both passing in Travis right now. I think this line would be the most interesting to you, considering it's the line that loads the plugin for all of the tests. Since this is working, I'm afraid I'm unable to reproduce the issue at hand. Perhaps if you could provide a failing test I could look into it deeper? |
I actually left my job at the company where we had this problem yesterday, so I don't need this fixed anymore. I just thought that if there was an obvious change since 1.0.0 that could have caused it, you could have fixed it. But as it stands now, it seems fine for me. Thanks for your time! |
I think the only thing that changed is the version of Babel that transpiled the code, but I'm fine closing this until someone else experiences the same problem. |
Hi! Thanks for the great module! I think I have the same problem:
Here is the full error output — gist and here my gulpfile.js I have everything worked fine with version 1.0.0. But it seems the problem is in the dependencies. Because now, when I try again to use version 1.0.0, I get the same error. My Node version 5.7.0. |
@gaintsev, can you provide a failing test in the form of a PR? Because I can't repro. |
We together with my colleague did simple project here — https://github.com/gaintsev/postcss-nested-props-test We determined that the 1.0.0 version works fine. But the latest version causes an error. I hope this will help solve the problem. |
I'm pretty sure |
Yes. It works. ) |
Maybe you could add this to the Readme, I had this issue on Node v5.10.1, adding .default fixed it for me too. (I'm using webpack) |
This should be fixed in v1.1.1 (published). There is a PR, but it's failing until postcss is updated. |
v1.1.5: Fix issue #5, retire Babel, update deps
When I use the plugin locally on my Mac (OSX 10.11.1 with Node 5.0.0), it works great!
If I run it on my Continuous Integration Platform (Ubuntu, Node 4.2), it fails while shouting
When I force the
package.json
to use 1.0.0, it works great, but 1.0.2 and 1.1.0 have this error.The text was updated successfully, but these errors were encountered: