feat: support outputting bytes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vados <[email protected]>
|
hi @jedisct1 would you mind taking a look at this? |
|
Thanks for the review! 🙇 -- I'd appreciate a release so I can get rid of my vendored code! :) |
|
Ahh @jedisct1, if you wouldn't mind -- a IIRC projects that use git dependencies can't be released. |
t3hmrman
added a commit
to VADOSWARE/pg_idkit
that referenced
this pull request
Oct 30, 2023
Now that the PR to rust-uuidv6 (jedisct1/rust-uuidv6#1), it looks like we can remove the vendored code that added support for outputting bytes. This commit removes the vendored code and uses a published version of uuidv6. Signed-off-by: vados <[email protected]>
t3hmrman
added a commit
to VADOSWARE/pg_idkit
that referenced
this pull request
Oct 30, 2023
Now that the PR to rust-uuidv6 (jedisct1/rust-uuidv6#1), it looks like we can remove the vendored code that added support for outputting bytes. This commit removes the vendored code and uses a published version of uuidv6. Signed-off-by: vados <[email protected]>
|
Done. |
t3hmrman
added a commit
to VADOSWARE/pg_idkit
that referenced
this pull request
Oct 30, 2023
Now that the PR to rust-uuidv6 (jedisct1/rust-uuidv6#1), it looks like we can remove the vendored code that added support for outputting bytes. This commit removes the vendored code and uses a published version of uuidv6. Signed-off-by: vados <[email protected]>
t3hmrman
added a commit
to VADOSWARE/pg_idkit
that referenced
this pull request
Oct 30, 2023
Now that the PR to rust-uuidv6 (jedisct1/rust-uuidv6#1), it looks like we can remove the vendored code that added support for outputting bytes. This commit removes the vendored code and uses a published version of uuidv6. Signed-off-by: vados <[email protected]>
t3hmrman
added a commit
to VADOSWARE/pg_idkit
that referenced
this pull request
Oct 30, 2023
Now that the PR to rust-uuidv6 (jedisct1/rust-uuidv6#1), it looks like we can remove the vendored code that added support for outputting bytes. This commit removes the vendored code and uses a published version of uuidv6. Signed-off-by: vados <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vados [email protected]
Support outputting bytes (
[u8;16]) for generated UUIDv6s