We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warc/src/record.rs
Line 609 in b2b9dfc
WarcWriter already writes WARC/ in the headers, so setting the version to WARC/1.0 prints WARC/WARC/1.0 in the header.
WarcWriter
WARC/
WARC/1.0
WARC/WARC/1.0
also, shouldn't version be an enum? :)
The text was updated successfully, but these errors were encountered:
Good catch and thanks for reporting! I created #39 to fix.
I don't think so because the version could be arbitrary. For example:
warc/src/parser.rs
Lines 132 to 135 in b2b9dfc
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
warc/src/record.rs
Line 609 in b2b9dfc
WarcWriter
already writesWARC/
in the headers, so setting the version toWARC/1.0
printsWARC/WARC/1.0
in the header.also, shouldn't version be an enum? :)
The text was updated successfully, but these errors were encountered: