Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused imports and version fix #39

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Unused imports and version fix #39

merged 3 commits into from
Jan 2, 2024

Conversation

jedireza
Copy link
Owner

Fixes #38

Also fixed some lint errors by removing unused imports in warc_reader.

@jedireza jedireza requested a review from jhwgh1968 December 31, 2023 06:27
@jedireza jedireza mentioned this pull request Dec 31, 2023
Closed
jhwgh1968
jhwgh1968 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@jhwgh1968 jhwgh1968 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd why my code didn't catch this at the time. LGTM!

@jedireza jedireza merged commit b1b0a1d into master Jan 2, 2024
8 checks passed
@jedireza jedireza deleted the unused-imports-and-version-fix branch January 2, 2024 03:51
@jedireza
Copy link
Owner Author

jedireza commented Jan 2, 2024

Published as 0.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhwgh1968 jhwgh1968 jhwgh1968 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default version should be "1.0", not "WARC/1.0"
2 participants
@jedireza @jhwgh1968