Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated so it works in react native #3

Closed
wants to merge 1 commit into from

Conversation

machard
Copy link

@machard machard commented Apr 15, 2015

Hi,

as events is not available within react native environment, i updated package.json to use node-event-emitter

@jedireza
Copy link
Owner

Thanks for opening a pull request. I haven't worked with react-native yet.

as events is not available within react native environment

How does using node-event-emitter help with this? I see in this PR that you defined a browser directive and I'm not sure how this ties into the native environments. I'm also concerned that browserify and webpack may use this instead so it's scope may not be limited to react-native.

Also, node-event-emitter looks like it was created a year ago and is still at 0.0.1 which doesn't give me a lot of confidence.

@machard
Copy link
Author

machard commented Apr 15, 2015

it is based on this commit that got to react native 0.3.11
vjeux/react-native@dc4e8d1
You can also see facebook/react-native#10

node-event-emitter is a copy of node core events module without node specifities.
In react native, it is not node env so events is not available.

But you're right about browserify and webpack i guess..

@jedireza
Copy link
Owner

I just updated some deps and realized I forgot about this PR. Closing for now. Please create new issue or pull request if this is still relevant.

@jedireza jedireza closed this Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants