Use VersionAdmin.revision_manager rather than default_revision_manager #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I use only the default revision_manager, so i didn't need this, yet. But if it work and the unittests didn't fail i would merge this. |
added 4 commits
June 19, 2012 11:11
…nager. Fix test case counting registered models.
|
Rebased to the latest master and added tests. |
jedie
added a commit
that referenced
this pull request
Jun 20, 2012
Use VersionAdmin.revision_manager rather than default_revision_manager contributed by mlavin, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to support using a non-default
revision_manageron theCompareVersionAdmin. This is already support by the baseVersionAdmin. Still needs some tests which I'm happy to write. Just wanted to get the discussion started to see if this seemed like a reasonable approach.