Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python2 compatibility decorators #113

Merged
merged 2 commits into from
Jan 19, 2020
Merged

Remove python2 compatibility decorators #113

merged 2 commits into from
Jan 19, 2020

Conversation

jeremy-engel
Copy link
Contributor

Adds support for django 3.0

See https://docs.djangoproject.com/en/3.0/releases/3.0/#removed-private-python-2-compatibility-apis

The README indicates that python2 is not supported in the current
version, so there shouldn't by any issues removing these.

See https://docs.djangoproject.com/en/3.0/releases/3.0/#removed-private-python-2-compatibility-apis

The README indicates that python2 is not supported in the current
version, so there shouldn't by any issues removing these.
@coveralls
Copy link

coveralls commented Dec 5, 2019

Coverage Status

Coverage increased (+0.005%) to 84.629% when pulling 294656e on jeremy-engel:django-3.0-compat into 0c10b4c on jedie:master.

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #113 into master will decrease coverage by 0.56%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #113      +/-   ##
=========================================
- Coverage   78.47%   77.9%   -0.57%     
=========================================
  Files           4       4              
  Lines         432     439       +7     
  Branches      102     103       +1     
=========================================
+ Hits          339     342       +3     
- Misses         69      73       +4     
  Partials       24      24
Impacted Files Coverage Δ
reversion_compare/compare.py 84.5% <50%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40785fd...294656e. Read the comment docs.

@devlounge
Copy link

When could this be merged ?

@jedie
Copy link
Owner

jedie commented Jan 19, 2020

Thanks for contributing

@jedie
Copy link
Owner

jedie commented Jan 19, 2020

it's included in the v0.9 release: https://pypi.org/project/django-reversion-compare/0.9.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants