Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing booleans is awkward #57

Closed
LegoStormtroopr opened this issue Feb 1, 2016 · 6 comments
Closed

Comparing booleans is awkward #57

LegoStormtroopr opened this issue Feb 1, 2016 · 6 comments

Comments

@LegoStormtroopr
Copy link
Contributor

When comparing a boolean field that goes from True and False, sometimes it gives results like that below:

image

I'm having a look at how this could be improved.

@LegoStormtroopr
Copy link
Contributor Author

I think this is due to google-diff-match-patch being overly helpful. Fortunately, its just a function in amix-in to fix this.

@jedie
Copy link
Owner

jedie commented Feb 1, 2016

Looks better than the current version....

Please create a pull request to merge.

maybe also a good idea is something like this:
<del>{{ bool1 }}</del> changed to <ins>{{ bool2 }}</ins>

@LegoStormtroopr
Copy link
Contributor Author

Done, I've added translation fields for it too!

LegoStormtroopr added a commit to LegoStormtroopr/django-reversion-compare that referenced this issue Feb 1, 2016
@jedie
Copy link
Owner

jedie commented Feb 1, 2016

I just made <del>{{ bool1 }}</del> changed to <ins>{{ bool2 }}</ins> too.

Wait a moment i will commit soon.

@jedie
Copy link
Owner

jedie commented Feb 1, 2016

done: e535267

Please rebase ;)

LegoStormtroopr added a commit to LegoStormtroopr/django-reversion-compare that referenced this issue Feb 1, 2016
LegoStormtroopr added a commit to LegoStormtroopr/django-reversion-compare that referenced this issue Feb 1, 2016
@LegoStormtroopr
Copy link
Contributor Author

Hmmm, one of the tests is changed to compare None to False in a NullBooleanField, which is showing no change. I'll see what I can do to fix this

@jedie jedie closed this as completed in 0a9b465 Feb 3, 2016
jedie added a commit that referenced this issue Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants