Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good first issue? #8

Open
Eugleo opened this issue Jan 31, 2019 · 6 comments
Open

Good first issue? #8

Eugleo opened this issue Jan 31, 2019 · 6 comments

Comments

@Eugleo
Copy link

Eugleo commented Jan 31, 2019

Hey, is the project alive? I'd love to get involved, but I don't have much experience with racket (nor LSPs, for that matter). Could you point me to some good issues/places to start reading the code or give me some tips on how to start?

Also, what is the difference between this and https://github.com/theia-ide/racket-language-server/ ?

@jeapostrophe
Copy link
Owner

It is alive.

The other one started by someone looking at our implementation and deciding they wanted to do it differently and they forked and re-wrote a lot of stuff.

@Eugleo
Copy link
Author

Eugleo commented Feb 1, 2019

Great to hear that, thanks! And what about the entry points? Is there any work to be done suitable for a intermediate racketeer?

@Eugleo
Copy link
Author

Eugleo commented Apr 29, 2020

Hey, I decided to revive this old issue. I've gotten requests to integrate code formatting into my vscode extension magic-racket, and you have that listed as WIP as well.

I think it might be beneficial if I helped you to finish it off, instead of running with my own implementation (if you want/need some help, that is). @JJPro helped me to integrate your language server into the extension, so now the last thing that needs to be done is actually finish the feature in you LSP.

So, would you mind giving me some pointers on what is done, what needs to be done, and what to watch out for, in the context of document/selection formatting? Also, the old question still stands; if you've got any general insights about contributing to this project, I'd love to hear them.

@jeapostrophe
Copy link
Owner

I think that the right way to implement most features in Racket-LSP is to find the corresponding feature in DrRacket and then disentangle from DrR's GUI and then expose the feature through the LSP. In many cases, DrR has already been internally organized to do that, but we just haven't done enough spelunking yet.

@jryans
Copy link
Contributor

jryans commented Mar 23, 2023

I think this issue could be closed... It seems like the questions above have been answered.

spdegabrielle added a commit to spdegabrielle/racket-langserver that referenced this issue Mar 25, 2023
@spdegabrielle
Copy link
Contributor

PR to add advice from @jeapostrophe into README.md --> #99

jeapostrophe pushed a commit that referenced this issue Mar 26, 2023
Incorporating advice from #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants