Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: allow specifying ref/path as an alias #166

Merged
merged 2 commits into from
Feb 21, 2023
Merged

bug: allow specifying ref/path as an alias #166

merged 2 commits into from
Feb 21, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Feb 21, 2023

this also allows aliasing prefix: and system. (no idea why one might want to alias system, but I figure we can allow it)

I noticed this thread and realized people need to alias these as well:

@jdx jdx force-pushed the alias-path-ref branch 2 times, most recently from 4d71500 to 8ff086a Compare February 21, 2023 16:20
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 81.92% // Head: 82.09% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (4f58375) compared to base (ad88f62).
Patch coverage: 95.34% of modified lines in pull request are covered.

❗ Current head 4f58375 differs from pull request most recent head afd88a7. Consider uploading reports for the commit afd88a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   81.92%   82.09%   +0.17%     
==========================================
  Files          90       90              
  Lines        2854     2860       +6     
==========================================
+ Hits         2338     2348      +10     
+ Misses        516      512       -4     
Impacted Files Coverage Δ
src/cli/alias/get.rs 100.00% <ø> (ø)
src/cli/alias/ls.rs 88.88% <ø> (ø)
src/cli/alias/set.rs 100.00% <ø> (ø)
src/cli/alias/unset.rs 100.00% <ø> (ø)
src/cli/env.rs 100.00% <ø> (ø)
src/cli/global.rs 100.00% <ø> (ø)
src/cli/install.rs 81.08% <ø> (ø)
src/cli/local.rs 76.92% <ø> (ø)
src/cli/mod.rs 87.69% <ø> (ø)
src/cli/plugins/ls.rs 100.00% <ø> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdx jdx merged commit ed482f2 into main Feb 21, 2023
@jdx jdx deleted the alias-path-ref branch February 21, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant