Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mrml-core): use a single MrmlParser structure with a visitor pattern #317

Merged
merged 49 commits into from
Jul 30, 2023

Conversation

jdrouet
Copy link
Owner

@jdrouet jdrouet commented Jul 29, 2023

Todo

  • increase coverage
  • refactor to remove duplicates
  • improve error messages to always give span

jdrouet added 30 commits July 27, 2023 14:46
Signed-off-by: Jérémie Drouet <[email protected]>
jdrouet added 18 commits July 30, 2023 09:16
Signed-off-by: Jérémie Drouet <[email protected]>
Signed-off-by: Jérémie Drouet <[email protected]>
Signed-off-by: Jérémie Drouet <[email protected]>
Signed-off-by: Jérémie Drouet <[email protected]>
Signed-off-by: Jérémie Drouet <[email protected]>
Signed-off-by: Jérémie Drouet <[email protected]>
Signed-off-by: Jérémie Drouet <[email protected]>
Repository owner deleted a comment from codecov bot Jul 30, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #317 (08590cf) into main (40e74db) will increase coverage by 0.73%.
The diff coverage is 94.82%.

@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   92.39%   93.12%   +0.73%     
==========================================
  Files         222      230       +8     
  Lines       11880    12115     +235     
==========================================
+ Hits        10976    11282     +306     
+ Misses        904      833      -71     
Files Changed Coverage Δ
packages/mrml-core/src/mj_accordion/children.rs 100.00% <ø> (ø)
...ges/mrml-core/src/mj_accordion_element/children.rs 66.66% <ø> (-25.65%) ⬇️
packages/mrml-core/src/mj_accordion_text/mod.rs 100.00% <ø> (ø)
packages/mrml-core/src/mj_accordion_title/mod.rs 100.00% <ø> (ø)
packages/mrml-core/src/mj_attributes/children.rs 100.00% <ø> (ø)
packages/mrml-core/src/mj_attributes/mod.rs 100.00% <ø> (ø)
packages/mrml-core/src/mj_attributes_all/mod.rs 100.00% <ø> (ø)
packages/mrml-core/src/mj_body/children.rs 96.87% <ø> (ø)
packages/mrml-core/src/mj_body/mod.rs 100.00% <ø> (ø)
packages/mrml-core/src/mj_breakpoint/mod.rs 100.00% <ø> (ø)
... and 73 more

... and 1 file with indirect coverage changes

Signed-off-by: Jérémie Drouet <[email protected]>
@jdrouet jdrouet merged commit 840bb97 into main Jul 30, 2023
@jdrouet jdrouet deleted the parser-refactoring branch July 30, 2023 13:46
@github-actions github-actions bot mentioned this pull request Oct 7, 2023
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
@jdrouet jdrouet mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant