Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for commit message in release #1

Merged
merged 1 commit into from
May 3, 2016
Merged

add support for commit message in release #1

merged 1 commit into from
May 3, 2016

Conversation

cirulls
Copy link

@cirulls cirulls commented May 3, 2016

I added support for a commit message when finishing a release. My git setup forces me to provide a commit message when finishing a release (I believe this is not unusual in many git configurations) so I added a message parameter. As documented, this option is used only with the command 'release' action 'finish'. The default value is " " (which I admit is not very elegant), unfortunately the empty string would break compatibility when no message is passed. The format of the command is:

git flow release finish -m"{message}" {name}

This is in line with what suggested in nvie/gitflow#50

I added your GitHub ID as recommended in the ansible's module checklist and I dared to add mine as contributor.

@jdinunzio jdinunzio merged commit f98a5be into jdinunzio:devel May 3, 2016
@jdinunzio
Copy link
Owner

Thank you very much, Sandro!

Pull request merged.

@cirulls
Copy link
Author

cirulls commented May 3, 2016

Thanks, that was very quick! I added my comments on your module at ansible#372. Thanks for sharing this useful module, it made my work easier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants