Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Remote PE" fixes #24

Closed

Conversation

davidozog
Copy link

@davidozog davidozog commented Sep 30, 2024

Summary of changes

8f25d8c does a global search for "remote PE(s)", and replaces with "target PE(s)" in an attempt to resolve this issue:
https://github.com/orgs/openshmem-org/projects/5/views/1?pane=issue&itemId=78784978.

5e91123 replaces each instance of "specified PE" with "specified target PE", if so desired.

Proposal Checklist

  • Link to issue(s)
  • Changelog entry
  • Reviewed for changes to front matter
  • Reviewed for changes to back matter

@jdinan
Copy link
Owner

jdinan commented Sep 30, 2024

@davidozog This makes sense to merge into the doc edit branch since it touches everything. :) I will ask that we review this very carefully for escapes, as there are likely instances where we use some other modifier with "PE" other than "remote". Perhaps grep for PE, pick off the preceding word, and look for things that might be inconsistent?

We should also make a changelog (or possibly errata) entry for this change and what it was intended to clarify.

@jdinan
Copy link
Owner

jdinan commented Sep 30, 2024

The desired terminology is now "source" PE and "target" PE. Is that right?

@davidozog
Copy link
Author

This makes sense to merge into the doc edit branch since it touches everything. :) I will ask that we review this very carefully for escapes, as there are likely instances where we use some other modifier with "PE" other than "remote". Perhaps grep for PE, pick off the preceding word, and look for things that might be inconsistent?

Fortunately the variants of \ac.*{PE} were considered manually in this search/replace scheme (VS code w/ manual review).

Will try the suggested to discover variants of unknown " PE".

The desired terminology is now "source" PE and "target" PE. Is that right?

I would have guessed "initiator PE" but assuming that typo then yes?

@isubsmith
Copy link

Does "local PE" match to "target PE"? There were several "local PE {does something} to remote PE" that are now "local PE {does something} to target PE". should we change local to source or initiator as well?

@davidozog
Copy link
Author

davidozog commented Oct 3, 2024

@wokuno @BKP @maawad - please review, thanks!

@jdinan jdinan deleted the branch jdinan:osh-1.6-rc2-doc-edits November 3, 2024 22:36
@jdinan jdinan closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants