Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace default team with world team #10

Merged
merged 2 commits into from
Feb 21, 2020

Conversation

minsii
Copy link

@minsii minsii commented Feb 17, 2020

This PR contains two changes:

@minsii
Copy link
Author

minsii commented Feb 17, 2020

@jdinan @agrippa @naveen-rn @wrrobin could you please review?

@jdinan
Copy link
Owner

jdinan commented Feb 20, 2020

@minsii How do you want to handle updating default -> world team for the other sections?

@minsii
Copy link
Author

minsii commented Feb 20, 2020

@jdinan I have submitted separate PRs to the other section committee branches. Some of them have been already merged. You can see the PR list at openshmem-org#371

@jdinan
Copy link
Owner

jdinan commented Feb 21, 2020

Thanks, I had missed those other PRs. Did you get the instance of "default team" in the constants section? This is the place where the term is associated to SHMEM_TEAM_WORLD.

@jdinan jdinan merged commit 1a0a178 into jdinan:sec/ctx-teams Feb 21, 2020
@minsii
Copy link
Author

minsii commented Feb 21, 2020

Did you get the instance of "default team" in the constants section? This is the place where the term is associated to SHMEM_TEAM_WORLD.

Yes, it has been added into the front matter section.

jdinan pushed a commit that referenced this pull request Feb 28, 2020
jdinan pushed a commit that referenced this pull request Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants