Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow types to be defined by bare type expressions #145

Merged
merged 1 commit into from
May 24, 2017

Conversation

freddrake
Copy link
Collaborator

No description provided.

Copy link
Contributor

@econchick econchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick, otherwise it LGTM



def test_array_definition_by_expression(api):
pytest.skip("Union types not yet implemented.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this to be a decorator (doc example)



def test_definition_by_union_expression(api):
pytest.skip("Union types not yet implemented.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too

@codecov-io
Copy link

codecov-io commented May 24, 2017

Codecov Report

❗ No coverage uploaded for pull request base (v0.2.0-dev@890396e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             v0.2.0-dev     #145   +/-   ##
=============================================
  Coverage              ?   95.79%           
=============================================
  Files                 ?       42           
  Lines                 ?     2020           
  Branches              ?        0           
=============================================
  Hits                  ?     1935           
  Misses                ?       85           
  Partials              ?        0
Impacted Files Coverage Δ
ramlfications/parser/parser.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890396e...aa9eaa0. Read the comment docs.

@freddrake freddrake force-pushed the fd-type-definitions-by-expression branch from 8e6e195 to aa9eaa0 Compare May 24, 2017 18:15
@freddrake
Copy link
Collaborator Author

Converted skips to decorators.

@econchick econchick merged commit 9815c86 into v0.2.0-dev May 24, 2017
@freddrake freddrake deleted the fd-type-definitions-by-expression branch May 24, 2017 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants