-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow types to be defined by bare type expressions #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nitpick, otherwise it LGTM
|
||
|
||
def test_array_definition_by_expression(api): | ||
pytest.skip("Union types not yet implemented.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like this to be a decorator (doc example)
|
||
|
||
def test_definition_by_union_expression(api): | ||
pytest.skip("Union types not yet implemented.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This too
Codecov Report
@@ Coverage Diff @@
## v0.2.0-dev #145 +/- ##
=============================================
Coverage ? 95.79%
=============================================
Files ? 42
Lines ? 2020
Branches ? 0
=============================================
Hits ? 1935
Misses ? 85
Partials ? 0
Continue to review full report at Codecov.
|
8e6e195
to
aa9eaa0
Compare
Converted skips to decorators. |
No description provided.