Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popup): display should not trigger the scrollview to update #2773

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

oasis-cloud
Copy link
Collaborator

@oasis-cloud oasis-cloud commented Nov 20, 2024

🤔 这个变动的性质是?

  • 日常 bug 修复

🔗 相关 Issue

#2744

💡 需求背景和解决方案

增加块,防止 Taro 重新渲染整个页面。

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能
    • 更新了文本区域组件的占位符属性,以支持本地化。
  • 改进
    • 当未提供占位符时,文本区域组件将使用本地化的占位符值。
    • 弹出窗口组件的渲染逻辑进行了优化,确保更好的结构和性能。

Copy link

coderabbitai bot commented Nov 20, 2024

Walkthrough

该拉取请求对PopupTextArea组件进行了多个修改。Popup组件的导入语句顺序进行了调整,并且其渲染逻辑被更新以使用<View>组件包裹返回值。TextArea组件的placeholder属性的默认值从空字符串更改为undefined,并相应地更新了渲染逻辑,以支持本地化占位符的显示。这些更改保持了组件的核心功能不变。

Changes

文件路径 更改摘要
src/packages/popup/popup.taro.tsx 调整导入语句顺序,更新renderNode函数以使用<View>组件包裹返回值,保持现有功能不变。
src/packages/textarea/textarea.taro.tsx 更新TextAreaProps接口中的placeholder属性,defaultProps中的placeholder''更改为undefined,调整渲染逻辑以支持本地化占位符。
src/packages/textarea/textarea.tsx 更新defaultProps中的placeholderundefined,调整textarea元素的placeholder处理逻辑。

Possibly related PRs

Suggested labels

size/M, 3.x

Suggested reviewers

  • xiaoyatong

Poem

🐰 在草地上跳跃,欢声笑语,
PopupTextArea更美丽,
占位符不再空白,
本地化的温暖在心怀。
代码整齐如兔子跳,
变化中我们一起跑! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (2ab6b1e) to head (ebe924a).
Report is 3 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2773   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files         217      217           
  Lines       17830    17830           
  Branches     2609     2609           
=======================================
  Hits        14991    14991           
  Misses       2834     2834           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
src/packages/popup/popup.taro.tsx (1)

Line range hint 274-287: 使用 View 包装和 catchMove 属性可以有效阻止滚动穿透

这个修改通过在弹出层外层添加带有 catchMove 属性的 View 组件来阻止事件冒泡,可以有效解决在 Taro 中弹窗触发页面重新渲染的问题。这是一个恰当的解决方案。

建议在代码中添加注释说明这个修改的目的:

-      <View catchMove>
+      {/* 使用 catchMove 阻止事件冒泡,防止触发页面滚动更新 */}
+      <View catchMove>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between bd4b46c and af81875.

📒 Files selected for processing (3)
  • src/packages/popup/popup.taro.tsx (3 hunks)
  • src/packages/textarea/textarea.taro.tsx (0 hunks)
  • src/packages/textarea/textarea.tsx (0 hunks)
💤 Files with no reviewable changes (2)
  • src/packages/textarea/textarea.taro.tsx
  • src/packages/textarea/textarea.tsx
🔇 Additional comments (2)
src/packages/popup/popup.taro.tsx (2)

5-7: 导入语句的重新排序符合最佳实践

导入顺序的调整提高了代码的可读性,将相关的导入分组放在一起。

Also applies to: 14-14, 17-17


Line range hint 1-300: 代码实现符合问题修复的目标

  1. 使用 catchMove 是 Taro 框架推荐的阻止滚动穿透的方案
  2. 修改最小化且聚焦于解决特定问题
  3. 不影响组件的其他现有功能

建议:

  • 考虑添加单元测试验证这个修复
  • 在组件文档中说明这个行为变更

@xiaoyatong xiaoyatong merged commit d107304 into jdf2e:next Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants