Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loading): 适配鸿蒙 #2733

Merged
merged 2 commits into from
Nov 11, 2024
Merged

feat(loading): 适配鸿蒙 #2733

merged 2 commits into from
Nov 11, 2024

Conversation

xiaoyatong
Copy link
Collaborator

@xiaoyatong xiaoyatong commented Nov 11, 2024

Summary by CodeRabbit

  • 新功能

    • 新增 Notify 组件,版本为 3.0.0
  • 版本更新

    • Loading 组件版本更新至 3.0.0
    • 多个组件(包括 EmptyResultPageInfiniteLoading 等)版本均更新至 3.0.0
  • 其他

    • TimeDetail 组件标记为不导出。

Copy link

coderabbitai bot commented Nov 11, 2024

Walkthrough

本次更改主要集中在 src/config.json 文件的版本更新上。Loading 组件的版本从 2.0.0 更新至 3.0.0,同时新增了 Notify 组件,版本为 3.0.0。多个组件,包括 EmptyResultPageInfiniteLoadingPopupPullToRefreshSkeletonSwipeToastAvatarAvatarGroupCountDownPaginationPriceProgressSwiperSwiperItemTagVideoVirtualList,均更新至版本 3.0.0。此外,TimeDetail 组件被标记为 exportEmpty: true,表示不打算导出。

Changes

文件 更改摘要
src/config.json 更新 Loading 组件版本至 3.0.0,新增 Notify 组件(版本 3.0.0),更新多个组件版本至 3.0.0,并将 TimeDetail 标记为 exportEmpty: true

Possibly related PRs

Suggested labels

size/M, 3.x

Suggested reviewers

  • oasis-cloud

🐇 在草地上跳跃,版本更新来临,
组件齐欢笑,功能更精彩!
新增通知声,加载更顺畅,
兔子舞翩翩,庆祝这变化! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 3.x label Nov 11, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
src/config.json (1)

Line range hint 1-1024: 建议完善组件文档

多个组件(包括 Loading、Empty、ResultPage 等)已升级到 3.0.0 版本以支持鸿蒙系统。建议:

  1. 在组件描述中标注鸿蒙系统的兼容性信息
  2. 更新组件文档,说明在鸿蒙系统中的特殊使用注意事项
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7df2012 and f6714aa.

📒 Files selected for processing (1)
  • src/config.json (1 hunks)
🔇 Additional comments (2)
src/config.json (2)

Line range hint 1-1024: 版本一致性检查

注意到部分组件仍保持在 2.0.0 版本:

  • Sticky
  • SafeArea
  • Elevator
  • FixedNav
    等组件。

请确认这些组件是否也需要适配鸿蒙系统。如果需要,建议一并升级版本。

#!/bin/bash
# 检查仍在使用 2.0.0 版本的组件
rg '"version":\s*"2\.0\.0"' src/config.json

Line range hint 786-794: 版本升级变更确认

Loading 组件升级到 3.0.0 版本是为了适配鸿蒙系统。请确认以下几点:

  1. 是否已完成鸿蒙系统相关的适配测试
  2. 是否需要更新组件文档以反映新版本的变更
✅ Verification successful

版本升级变更已确认完成

根据代码库分析,Loading 组件升级到 3.0.0 版本是系统性升级的一部分:

  1. 相关文档已经存在:src/packages/loading/doc.mddoc.en-US.mddoc.zh-TW.mddoc.taro.md
  2. 版本 3.0.0 在构建脚本中被用作跨平台适配的标识,包括 Taro 和 RN 平台的导出控制
  3. 这是一个全局性的版本升级,用于标识组件是否已完成跨平台适配

无需额外操作,版本升级符合项目规范。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查是否存在相关的测试文件和文档更新
rg -g '*.md' -g '*.test.*' -g '*.spec.*' 'Loading.*3\.0\.0|HarmonyOS.*Loading'

Length of output: 1882


Script:

#!/bin/bash
# 检查 Loading 组件相关的文档和测试文件
fd -e md -e test.ts -e test.js -e spec.ts -e spec.js . | xargs rg -l "Loading"

# 检查 Loading 组件的源代码文件
fd Loading

# 检查版本升级相关的变更
rg -g '*.md' -g '*.ts' -g '*.js' -g '*.vue' "version.*3\.0\.0" -A 2 -B 2

Length of output: 3013

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (a9eeca5) to head (580310e).
Report is 1 commits behind head on V3.0.

Additional details and impacted files
@@           Coverage Diff           @@
##             V3.0    #2733   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         221      221           
  Lines       17867    17867           
  Branches     2676     2676           
=======================================
  Hits        15005    15005           
  Misses       2857     2857           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants