-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputNumber): correct onChange, onOverlimit event triggering timing when async & sync #2509
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4119a7d
fix(inputNumber): onOverlimit and onchange
Alex-huxiyang 4feb534
fix(inputNumber): onOverlimit and onchange
Alex-huxiyang 13d055b
Merge branch 'next' into hxy/inputnumber/731
Alex-huxiyang 7707cb0
chore: unify demo
Alex-huxiyang a5ede7a
chore: add test
Alex-huxiyang 34e3b0f
chore: add test
Alex-huxiyang 80c1122
Merge branch 'next' into hxy/inputnumber/731
Alex-huxiyang 75f1ee0
fix: not overlimit
Alex-huxiyang b3951b3
fix: reset demo
Alex-huxiyang aabb8b6
Merge branch 'next' into hxy/inputnumber/731
Alex-huxiyang 8ac32a3
fix: test
Alex-huxiyang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码无误,但请添加测试!
handleBlur
函数基于夹紧输入设置影子值,并在异步模式下有条件地调用handleValueChange
。根据静态分析工具的提示,以下代码行未覆盖测试:#L226-L230。请添加相应的测试。
您希望我生成单元测试代码还是创建一个 GitHub issue 来跟踪此任务?
Tools
GitHub Check: codecov/patch