Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taro-form-demo): 点击演示demo表单内的重置会触发提交表单事件bug修复 #2415

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Skedush
Copy link
Contributor

@Skedush Skedush commented Jul 4, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

#2195
该提交引起的问题

💡 需求背景和解决方案

https://nutui.jd.com/taro/react/2x/#/zh-CN/component/form
该地址的表单演示页面点击重置会触发表单提交事件

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 改进
    • 将所有 Button 组件中的 formType 属性更改为 nativeType

Copy link

coderabbitai bot commented Jul 4, 2024

Walkthrough

这次修改主要集中在将多个文件中的 Button 组件的属性 formType 更换为 nativeType。这解决了在 Taro 框架中,无法为按钮设置原始类型(如 submitreset)的问题。

Changes

文件路径 变更摘要
src/.../demo1.tsx Button 组件的 formType 属性修改为 nativeType
src/.../demo2.tsx Button 组件的 formType 属性修改为 nativeType
src/.../demo4.tsx Button 组件的 formType 属性修改为 nativeType
src/.../demo7.tsx Button 组件的 formType 属性修改为 nativeType

Possibly related issues

  • jdf2e/nutui-react#2193 - 该问题提到 Taro 版本 Button 无法设置 nativeType 属性,此次变更正好解决了这个问题。

Poem

按钮属性大变更,
formType 化作云烟,
nativeType 崭露头角,
未来一片光明,
跨端打包无压力,
开发体验更得力。 🐰🚀


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f2d2b3d and abc4afe.

Files selected for processing (4)
  • src/packages/form/demos/taro/demo1.tsx (1 hunks)
  • src/packages/form/demos/taro/demo2.tsx (1 hunks)
  • src/packages/form/demos/taro/demo4.tsx (1 hunks)
  • src/packages/form/demos/taro/demo7.tsx (1 hunks)
Files skipped from review due to trivial changes (2)
  • src/packages/form/demos/taro/demo1.tsx
  • src/packages/form/demos/taro/demo7.tsx
Additional comments not posted (4)
src/packages/form/demos/taro/demo4.tsx (2)

46-46: 确认属性更改

formType 更改为 nativeType 是正确的。请确保所有相关的表单按钮都已更新。


49-49: 确认属性更改

formType 更改为 nativeType 是正确的。请确保所有相关的表单按钮都已更新。

src/packages/form/demos/taro/demo2.tsx (2)

48-48: 确认属性更改

formType 更改为 nativeType 是正确的。请确保所有相关的表单按钮都已更新。


51-51: 确认属性更改

formType 更改为 nativeType 是正确的。请确保所有相关的表单按钮都已更新。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xiaoyatong xiaoyatong merged commit 958d83d into jdf2e:next Jul 5, 2024
@coderabbitai coderabbitai bot mentioned this pull request Oct 25, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants