Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uploader): 京东小程序中可上传时可选择图片和视频 #2410

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

xueshufive
Copy link
Contributor

@xueshufive xueshufive commented Jul 3, 2024

🤔 这个变动的性质是?

  • [ ✅ ] 功能增强

🔗 相关 Issue

💡 需求背景和解决方案

需求背景:

  1. 京东小程序中需要支持一个按钮上传图片或者视频,现有uploader组件只能选择相册中的图片
  2. 京东小程序中的chooseMedia支持同时选择图片或视频,但uploader组件中没有支持

解决方案:

对京东小程序端的chooseMedia进行支持

使用方法
mediaType={['image', 'video','mix']}

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • [ ✅ ] 文档已补充或无须补充
  • [ ✅] 代码演示已提供或无须提供
  • [ ✅ ] TypeScript 定义已补充或无须补充
  • [ ✅ ] fork仓库代码是否为最新避免文件冲突
  • [ ✅ ] Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能
    • 改进了媒体选择功能,现在在微信小程序和京东环境中提供更好的支持。

Copy link

coderabbitai bot commented Jul 3, 2024

Walkthrough

此次更改主要涉及在选择媒体源的条件中添加JD环境。新的逻辑是,如果检测到当前环境为WEAPP或JD,并且chooseMedia可用,则代码将在所有其他环境中使用chooseImage API

Changes

文件路径 更改摘要
src/.../uploader/uploader.taro.tsx 修改了InternalUploader组件中选择媒体源的条件,将JD环境添加到原有的WEAPP环境中。

Poem

✨在代码中添加了新意,
环境识别更加统一。
JD与WEAPP共舞飞,
媒体选择不再分离。
小兔子欢欣鼓舞,送上祝福语,
变化之下皆美丽!🌟

Tip

AI model upgrade

gpt-4o model for reviews and chat is now live

OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 642285b and 51c4fe2.

Files selected for processing (1)
  • src/packages/uploader/uploader.taro.tsx (1 hunks)
Additional comments not posted (1)
src/packages/uploader/uploader.taro.tsx (1)

255-256: 新增对京东小程序环境的支持

代码变更在 _chooseImage 函数中增加了对京东小程序环境的支持。现在,如果环境是 WEAPPJD,并且存在 chooseMedia,将使用 chooseMedia API。这是一个很好的功能增强,符合需求背景中的说明。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xiaoyatong xiaoyatong merged commit 5c92953 into jdf2e:next Jul 3, 2024
5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants