Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card): add card hide price and shop usage #2292

Merged
merged 2 commits into from
May 29, 2024

Conversation

wenlingang
Copy link
Contributor

@wenlingang wenlingang commented May 28, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

issue 2287

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能

    • Card 组件增加了隐藏价格和店铺信息的新功能。
    • CardDemo 组件新增了 Demo6 示例组件,展示隐藏价格和店铺信息的用法。
  • 文档

    • 更新了 Card 组件的文档,增加了关于隐藏价格和店铺信息的新章节。
    • 提供了新的演示代码片段,展示如何使用隐藏价格和店铺信息功能。

Copy link

coderabbitai bot commented May 28, 2024

Walkthrough

这些更改主要是为 Card 组件引入了基于某些值(如 pricepriceTagvipPriceshopDescriptiondeliveryshopName)的条件渲染。此外,还在文档中添加了一个新的演示组件 Demo6,并更新了相关的翻译和文档内容。

Changes

文件路径 变更摘要
src/packages/card/card.taro.tsx Card 组件添加了基于 pricepriceTagvipPriceshopDescriptiondeliveryshopName 存在的条件渲染。
src/packages/card/demo.taro.tsx CardDemo 组件引入了新的翻译键 customerWithoutPrice,并渲染了新的 Demo6 组件。
src/packages/card/demo.tsx 添加了新的演示组件 Demo6 并更新了翻译。
src/packages/card/demos/h5/demo6.tsx 新增了 Demo6 组件,渲染了一个带有图片、标题和描述的卡片。
src/packages/card/doc.en-US.md 在文档中引入了一个新的 "Hide price and shop" 部分,包括演示代码片段。
src/packages/card/doc.md 在文档中引入了一个新的 "不显示价格和店铺" 部分,包括演示代码片段。
src/packages/card/doc.taro.md 在文档中引入了一个新的 "不显示价格和店铺" 部分,包括演示代码片段。
src/packages/card/doc.zh-TW.md 在文档中引入了一个新的部分,涉及在卡片组件中隐藏价格和店铺信息。

代码变更如春风,
条件渲染显轻松。
文档更新添新意,
演示组件映心中。
价格店铺随意隐,
灵活展示更从容。
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range and nitpick comments (4)
src/packages/card/doc.md (1)

Line range hint 85-85: 请检查并修正无效的链接片段。

- [ConfigProvider 组件](#/zh-CN/component/configprovider)
+ [ConfigProvider 组件](../path/to/configprovider)
src/packages/card/doc.zh-TW.md (1)

Line range hint 85-85: 請檢查並修正無效的鏈接片段。

- [ConfigProvider 組件](#/zh-CN/component/configprovider)
+ [ConfigProvider 組件](../path/to/configprovider)
src/packages/card/doc.taro.md (1)

Line range hint 85-85: 请检查并修正无效的链接片段。

- [ConfigProvider 组件](#/zh-CN/component/configprovider)
+ [ConfigProvider 组件](../path/to/configprovider)
src/packages/card/doc.en-US.md (1)

Line range hint 85-85: Please check and correct the invalid link fragment.

- [ConfigProvider component](#/en-US/component/configprovider)
+ [ConfigProvider component](../path/to/configprovider)

Comment on lines +67 to +74
{priceTag ||
(vipPrice && (
<Price
size="normal"
className={`${classPrefix}-right-price-origin`}
price={vipPrice}
/>
))}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码更改正确,但建议在此逻辑块上方添加注释,说明为什么使用 priceTagvipPrice 的条件渲染,以提高代码的可维护性。

+ // 使用 `priceTag` 或 `vipPrice` 来避免显示重复信息
  {priceTag ||
    (vipPrice && (
      <Price
        size="normal"
        className={`${classPrefix}-right-price-origin`}
        price={vipPrice}
      />
    ))}

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
{priceTag ||
(vipPrice && (
<Price
size="normal"
className={`${classPrefix}-right-price-origin`}
price={vipPrice}
/>
))}
// 使用 `priceTag` 或 `vipPrice` 来避免显示重复信息
{priceTag ||
(vipPrice && (
<Price
size="normal"
className={`${classPrefix}-right-price-origin`}
price={vipPrice}
/>
))}

Comment on lines +67 to +74
{priceTag ||
(vipPrice && (
<Price
size="normal"
className={`${classPrefix}-right-price-origin`}
price={vipPrice}
/>
))}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码更改正确,但建议在此逻辑块上方添加注释,说明为什么使用 priceTagvipPrice 的条件渲染,以提高代码的可维护性。

+ // 使用 `priceTag` 或 `vipPrice` 来避免显示重复信息
  {priceTag ||
    (vipPrice && (
      <Price
        size="normal"
        className={`${classPrefix}-right-price-origin`}
        price={vipPrice}
      />
    ))}

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
{priceTag ||
(vipPrice && (
<Price
size="normal"
className={`${classPrefix}-right-price-origin`}
price={vipPrice}
/>
))}
// 使用 `priceTag` 或 `vipPrice` 来避免显示重复信息
{priceTag ||
(vipPrice && (
<Price
size="normal"
className={`${classPrefix}-right-price-origin`}
price={vipPrice}
/>
))}

@xiaoyatong xiaoyatong merged commit 8855689 into jdf2e:next May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants