-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(card): add card hide price and shop usage #2292
Conversation
Walkthrough这些更改主要是为 Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Outside diff range and nitpick comments (4)
src/packages/card/doc.md (1)
Line range hint
85-85
: 请检查并修正无效的链接片段。- [ConfigProvider 组件](#/zh-CN/component/configprovider) + [ConfigProvider 组件](../path/to/configprovider)src/packages/card/doc.zh-TW.md (1)
Line range hint
85-85
: 請檢查並修正無效的鏈接片段。- [ConfigProvider 組件](#/zh-CN/component/configprovider) + [ConfigProvider 組件](../path/to/configprovider)src/packages/card/doc.taro.md (1)
Line range hint
85-85
: 请检查并修正无效的链接片段。- [ConfigProvider 组件](#/zh-CN/component/configprovider) + [ConfigProvider 组件](../path/to/configprovider)src/packages/card/doc.en-US.md (1)
Line range hint
85-85
: Please check and correct the invalid link fragment.- [ConfigProvider component](#/en-US/component/configprovider) + [ConfigProvider component](../path/to/configprovider)
{priceTag || | ||
(vipPrice && ( | ||
<Price | ||
size="normal" | ||
className={`${classPrefix}-right-price-origin`} | ||
price={vipPrice} | ||
/> | ||
))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码更改正确,但建议在此逻辑块上方添加注释,说明为什么使用 priceTag
或 vipPrice
的条件渲染,以提高代码的可维护性。
+ // 使用 `priceTag` 或 `vipPrice` 来避免显示重复信息
{priceTag ||
(vipPrice && (
<Price
size="normal"
className={`${classPrefix}-right-price-origin`}
price={vipPrice}
/>
))}
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
{priceTag || | |
(vipPrice && ( | |
<Price | |
size="normal" | |
className={`${classPrefix}-right-price-origin`} | |
price={vipPrice} | |
/> | |
))} | |
// 使用 `priceTag` 或 `vipPrice` 来避免显示重复信息 | |
{priceTag || | |
(vipPrice && ( | |
<Price | |
size="normal" | |
className={`${classPrefix}-right-price-origin`} | |
price={vipPrice} | |
/> | |
))} |
{priceTag || | ||
(vipPrice && ( | ||
<Price | ||
size="normal" | ||
className={`${classPrefix}-right-price-origin`} | ||
price={vipPrice} | ||
/> | ||
))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码更改正确,但建议在此逻辑块上方添加注释,说明为什么使用 priceTag
或 vipPrice
的条件渲染,以提高代码的可维护性。
+ // 使用 `priceTag` 或 `vipPrice` 来避免显示重复信息
{priceTag ||
(vipPrice && (
<Price
size="normal"
className={`${classPrefix}-right-price-origin`}
price={vipPrice}
/>
))}
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
{priceTag || | |
(vipPrice && ( | |
<Price | |
size="normal" | |
className={`${classPrefix}-right-price-origin`} | |
price={vipPrice} | |
/> | |
))} | |
// 使用 `priceTag` 或 `vipPrice` 来避免显示重复信息 | |
{priceTag || | |
(vipPrice && ( | |
<Price | |
size="normal" | |
className={`${classPrefix}-right-price-origin`} | |
price={vipPrice} | |
/> | |
))} |
🤔 这个变动的性质是?
🔗 相关 Issue
issue 2287
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
新功能
Card
组件增加了隐藏价格和店铺信息的新功能。CardDemo
组件新增了Demo6
示例组件,展示隐藏价格和店铺信息的用法。文档
Card
组件的文档,增加了关于隐藏价格和店铺信息的新章节。