Fix up helptext and validation to be a bit saner #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created explicit helptext commands on each of the configuration objects. That means that we don't have to use the defaults for the helptext anymore, so can set actual defaults if we want to. That also means that none of the validation/post_init functions have to worry about fields being set to helptext strings.
I've also tidied up validation, such that all the validation commands are called in a cascading manner when we are ready, rather than in an adhoc manner from other functions.
The live publisher test is failing, but it is something to do with not finding a proxy publisher resource. This is unrelated to this change and we are just about to remove the proxy publisher stuff, so I'm not going to worry about it for now.