Add CNF NFD generation to build command #8
Conversation
…-cli-extensions into add-cnf-generation
…extensions into jl/add-cnf-generation
…extensions into jl/add-cnf-generation
…extensions into jl/add-cnf-generation
There was a problem hiding this comment.
On the whole looks very good. Most of my comments are about the need to explain what is going on rather than coding errors.
I have run azdev aosm style and it throws a load of errors, most of which should be fixed. (I always get an error with flake8 failing to run with ValueError: Error code '#' supplied to 'ignore' option does not match '^[A-Z]{1,3}[0-9]{0,3}$' which I never got to the bottom of, but there are plenty other errors.)
Personally, I cheated a bit for fixing them up and installed python-static-checks into the az aosm virtual environment. This is a tool used in quicksilver projects, and running python-static-checks fmt fixed a load of the errors for me automatically. I've written in setup.md how you install it.
There was a problem hiding this comment.
On the whole looks very good. Most of my comments are about the need to explain what is going on rather than coding errors.
I have run azdev aosm style and it throws a load of errors, most of which should be fixed. (I always get an error with flake8 failing to run with ValueError: Error code '#' supplied to 'ignore' option does not match '^[A-Z]{1,3}[0-9]{0,3}$' which I never got to the bottom of, but there are plenty other errors.)
Personally, I cheated a bit for fixing them up and installed python-static-checks into the az aosm virtual environment. This is a tool used in quicksilver projects, and running python-static-checks fmt fixed a load of the errors for me automatically. I've written in setup.md how you install it.
|
|
||
| # only add the parameter name (e.g. from {deployParameter.zone} only param = zone) | ||
| param = v.split(".", 1)[1] | ||
| param = param.split("}", 1)[0] |
There was a problem hiding this comment.
Anything we should do here to guard against whoever wrote the file putting too many spaces in somewhere?
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.