Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl/add unit testing #32

Merged
merged 17 commits into from
Jul 5, 2023
Merged

Conversation

jordlay
Copy link
Collaborator

@jordlay jordlay commented Jun 20, 2023


I've added UTs for the things that could be done easily without worrying about interacting with Azure. That means the generate config and build commands.

They currently just check that the code doesn't hit any errors and that something is output. We could later validate that the output is sensible, but that is a lot more effort and a job for another day.

In addition:

  • I've tweaked the code so that file paths in the input files are relative to that input file (I think that is the right thing to do, but it also made writing UTs more intuitive).
  • Fixed up some linting

Don't worry about reviewing the files in the mock_* folders, they are just example Helm charts and other artifacts.

Copy link
Collaborator

@Cyclam Cyclam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but otherwise looks good. Thanks :-)

src/aosm/azext_aosm/_configuration.py Show resolved Hide resolved
src/aosm/azext_aosm/_configuration.py Outdated Show resolved Hide resolved
src/aosm/azext_aosm/_configuration.py Outdated Show resolved Hide resolved
src/aosm/azext_aosm/tests/latest/test_cnf.py Outdated Show resolved Hide resolved
src/aosm/azext_aosm/tests/latest/test_cnf.py Outdated Show resolved Hide resolved
src/aosm/azext_aosm/tests/latest/test_cnf.py Outdated Show resolved Hide resolved
src/aosm/azext_aosm/tests/latest/test_cnf.py Outdated Show resolved Hide resolved
src/aosm/azext_aosm/tests/latest/test_cnf.py Outdated Show resolved Hide resolved
src/aosm/azext_aosm/tests/latest/test_nsd.py Outdated Show resolved Hide resolved
src/aosm/azext_aosm/tests/latest/test_nsd.py Show resolved Hide resolved
@jamiedparsons jamiedparsons merged commit b5b70b9 into add-aosm-extension Jul 5, 2023
@jamiedparsons jamiedparsons deleted the jl/add-unit-testing branch July 27, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants