Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl/fix style #21

Merged
merged 9 commits into from
Jun 7, 2023
Merged

Jl/fix style #21

merged 9 commits into from
Jun 7, 2023

Conversation

jordlay
Copy link
Collaborator

@jordlay jordlay commented Jun 6, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@patrykkulik-microsoft
Copy link
Collaborator

There are a few weird docstrings in the codebase which your linting seems to ignore. For example in custom.py:

``
Publish a generated definition.

:param cmd: :param client: :type client: HybridNetworkManagementClient :param
definition_type: VNF or CNF :param config_
file:
Path to the config file for the NFDV    :param definition_file: Optional path to a
bicep template to deploy, in case the user                       wants to edit the
built NFDV template. If omitted, the default                       built NFDV
template will be used.    :param parameters_json_
file:
Optional path to a parameters file for the bicep file,                      in case
the user wants to edit the built NFDV template. If                      omitted,
parameters from config will be turned into parameters                      for the
bicep file    :param manifest_
file:
Optional path to an override bicep template to deploy
manifests    :param manifest_parameters_json_
file:
:param cmd:
:param client:

``

@jordlay jordlay merged commit 649ace6 into add-aosm-extension Jun 7, 2023
@jamiedparsons jamiedparsons deleted the jl/fix-style branch July 27, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants