Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker dependency option to oras in setup.py #164

Merged

Conversation

Cyclam
Copy link
Collaborator

@Cyclam Cyclam commented Mar 27, 2024

The Oras library we use has the Python docker module as an optional requirement. We do use that branch of Oras's code, so need the module. We didn't have the optional requirement turned on, so if you didn't already have the Python docker module installed, the AOSM CLI broke.

This PR adds the docker option into setup.py.

Testing

Tobias Weiserth hit this. Confirmed fixed after this change.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Cyclam Cyclam requested a review from sunnycarter as a code owner March 27, 2024 11:10
@patrykkulik-microsoft patrykkulik-microsoft merged commit 9b6fcde into main Mar 27, 2024
1 check failed
patrykkulik-microsoft added a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants