Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bool in schema bug #160

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Fix bool in schema bug #160

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
638f1ba
check for dict before checking type
Mar 15, 2024
25ee61d
Update src/aosm/azext_aosm/build_processors/base_processor.py
Cyclam Mar 16, 2024
5691fe9
Revert oneOf/anyOf split processing.
Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/aosm/azext_aosm/build_processors/base_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,18 @@ def generate_values_mappings(
# Loop through each property in the schema.
for subschema_name, subschema in schema["properties"].items():

if "type" not in subschema:
if ["oneOf", "anyOf"] in subschema:
if isinstance(subschema, dict) and "type" not in subschema:
if "oneOf" in subschema:
raise InvalidArgumentValueError(
f"The subschema '{subschema_name}' does not contain a type.\n"
"It contains 'anyOf' or 'oneOf' logic, which is not valid for AOSM.\n"
"It contains 'oneOf' logic, which is not valid for AOSM.\n"
"Please remove this from your values.schema.json and provide a concrete type "
"or remove the schema and the CLI will generate a generic schema."
)
if "anyOf" in subschema:
raise InvalidArgumentValueError(
f"The subschema '{subschema_name}' does not contain a type.\n"
"It contains 'anyOf' logic, which is not valid for AOSM.\n"
Cyclam marked this conversation as resolved.
Show resolved Hide resolved
"Please remove this from your values.schema.json and provide a concrete type "
"or remove the schema and the CLI will generate a generic schema."
)
Expand Down
Loading