Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pk5/add image parsing #137

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Pk5/add image parsing #137

merged 8 commits into from
Jan 30, 2024

Conversation

patrykkulik-microsoft
Copy link
Collaborator

  1. The _find_image_lines function now points at the template generated by the helm template command to find lines that contain images. We no longer need recursive search because all images are in the template. We also wanted to make the image list a Set() because images should be unique
  2. Minor fix to how processors are accessed in the _validate_helm_template function
  3. Two minor bug fixes in the artifact.py function to avoid infinite loop and trying to access undefined variables
  4. Modified test_pre_validate_build.py because point (2) has broken the test
  5. Added testing of the image finding, as well as some utility functions for unit tests
  6. Added some input file templates for unit tests because without templating it is very difficult to make an OnboardingCNFCLIHandler that has the correct config.

Copy link
Collaborator

@Cyclam Cyclam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff. One minor possible refactor, and some generaly thoughts on unit tests, but even without those changes it's good to merge, so hitting approve. Up to you if you do want to make the changes.

src/aosm/HISTORY.rst Outdated Show resolved Hide resolved
@patrykkulik-microsoft patrykkulik-microsoft merged commit 7af973e into main Jan 30, 2024
@patrykkulik-microsoft patrykkulik-microsoft deleted the pk5/add_image_parsing branch January 30, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants