Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edited input file #133

Merged
merged 1 commit into from
Jan 17, 2024
Merged

edited input file #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/aosm/azext_aosm/configuration_models/onboarding_base_input_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class OnboardingBaseInputConfig(ABC):

location: str = field(
default="",
metadata={"comment": "Azure location to use when creating resources."},
metadata={"comment": "Azure location to use when creating resources e.g uksouth"},
)
publisher_name: str = field(
default="",
Expand All @@ -37,12 +37,12 @@ class OnboardingBaseInputConfig(ABC):
)
},
)
acr_artifact_store_name: str | None = field(
acr_artifact_store_name: str = field(
default="",
metadata={
"comment": (
"Optional. Name of the ACR Artifact Store resource.\n"
"Will be created if it does not exist (with a default name if none is supplied)."
"Name of the ACR Artifact Store resource.\n"
"Will be created if it does not exist."
)
},
)
Expand All @@ -55,3 +55,5 @@ def validate(self):
raise ValidationError("Publisher name must be set")
if not self.publisher_resource_group_name:
raise ValidationError("Publisher resource group name must be set")
if not self.acr_artifact_store_name:
raise ValidationError("Artifact store name must be set")
2 changes: 1 addition & 1 deletion src/aosm/azext_aosm/configuration_models/onboarding_cnf_input_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class OnboardingCNFInputConfig(OnboardingNFDBaseInputConfig):

# TODO: Add better comment for images as not a list
images: ImageSourceConfig = field(
default_factory=ImageSourceConfig, metadata={"comment": "List of images "}
default_factory=ImageSourceConfig, metadata={"comment": "Source of images to be included in the CNF."}
)
helm_packages: List[HelmPackageConfig] = field(
default_factory=lambda: [HelmPackageConfig()],
Expand Down
Loading