This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
Fixing Ansible 2.7.0 deprication warnings #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
timorunge
commented
Jun 19, 2018
timorunge
commented
- Remving travis deprecation warning - Moving from "--sudo" to "--become"
- For further details take a look at: https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.7.html#using-a-loop-on-a-package-module-via-squash-actions
jdauphant
reviewed
Jun 19, 2018
There was a problem hiding this comment.
@timorunge Thanks for the work. I just one comment on the "ignore_errors"
| @@ -30,6 +30,7 @@ | |||
| dest: "{{ nginx_conf_dir }}/sites-enabled/{{ item.key }}.conf" | |||
| with_dict: "{{ nginx_sites }}" | |||
| when: (item.key not in nginx_remove_sites) and (item.key not in nginx_disabled_sites) | |||
| ignore_errors: "{{ ansible_check_mode }}" | |||
There was a problem hiding this comment.
If you're running Ansible in "check mode" (ansible-playbook main.yml -i inventory/hosts -b --check) you're executing the task "Create the configurations for sites" which works fine; but the task "Create links for sites-enabled" is failing since the source files are not available.
... "msg": "src file does not exist, use \"force=yes\" if you really want to create the link: /etc/nginx/sites-available/XXX.conf", "path": "/etc/nginx/sites-enabled/XXX.conf", "src": "/etc/nginx/sites-available/XXX.conf", "state": "absent" ...
jdauphant
approved these changes
Jun 19, 2018
| @@ -30,6 +30,7 @@ | |||
| dest: "{{ nginx_conf_dir }}/sites-enabled/{{ item.key }}.conf" | |||
| with_dict: "{{ nginx_sites }}" | |||
| when: (item.key not in nginx_remove_sites) and (item.key not in nginx_disabled_sites) | |||
| ignore_errors: "{{ ansible_check_mode }}" | |||
mrwacky42
added a commit
to HeadspaceMeditation/ansible-role-nginx
that referenced
this pull request
Jan 18, 2020
* Explicitly setting the nginx configuration file in (jdauphant#223) the "check nginx configuration" handler. * Fixing Ansible 2.7.0 deprication warnings (jdauphant#225) * * Fixing Ansible 2.7.0 deprication warnings For further details take a look at: https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.7.html#using-a-loop-on-a-package-module-via-squash-actions * * Remving travis deprecation warning - Moving from "--sudo" to "--become" * * Ignoring symlinks errors during ansible_check_mode * Small spelling correction (jdauphant#228) * Add support to declare nginx modules in config file (jdauphant#227) * We can declare nginx modules now * We can declare nginx modules now * Correct load_module definition in template * Add task to remove `default.conf` from sites-enabled/ (jdauphant#231) * Add task to remove `default.conf` from sites-enabled/ * Check if `default` site is not inside user config * fix modules definition and add README section about this feature (jdauphant#232) * Fix typo in modules config and restrict to EPEL (jdauphant#232) (jdauphant#235) * Fix typo in modules config and restrict to EPEL (jdauphant#232) * Fixes warning from duplicate when's in modules configuration (jdauphant#233) * Extends support for configuring modules (jdauphant#236) (jdauphant#237) Module configuration should now work for the following: Centos/RHEL with either EPEL or Official Nginx repo Debian/Ubuntu with either standard APT repo or Official Nginx repo Please see issue jdauphant#236 for further details. * Update README.md * download mime.types file if it's missing (jdauphant#241) * configuration: allow templates for conf.d independent files (jdauphant#238) * Fix for jdauphant#242 Stick to ansible-lint rules. (jdauphant#243) * trailing whitespace * [701] Role info should contain description * [601] Don't compare to literal True/False * [502] All tasks should be named * [206] Variables should have spaces before and after: {{ var_name }} * skip_ansible_lint rule [403] Package installs should not use latest * [204] Lines should be no longer than 160 chars Co-authored-by: Timo Runge <[email protected]> Co-authored-by: TheSycamore <[email protected]> Co-authored-by: Dmitry Ge <[email protected]> Co-authored-by: Tommaso <[email protected]> Co-authored-by: Perry Kollmorgen <[email protected]> Co-authored-by: Julien DAUPHANT <[email protected]> Co-authored-by: Tony Crowe <[email protected]> Co-authored-by: paulrbr-fl <[email protected]> Co-authored-by: Bas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.