Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --treeshake option to work with node 22 #3613

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

kashz
Copy link
Contributor

@kashz kashz commented Jul 23, 2024

To work with Node.js 22, the --treeshake option has been removed from the build command.

#3591 (comment)

Build Diff

Here are the build differences observed after making these changes:

--- packages/cli/dist/index.mjs
+++ packages/cli/dist/index.mjs
@@ -1,10 +1,13 @@
 #!/usr/bin/env node
-import Chalk from 'chalk';
-import Sywac from 'sywac';
-import * as Gitbeaker from '@gitbeaker/rest';
-import API_MAP from '@gitbeaker/core/map.json' assert { type: 'json' };
-import { decamelize, depascalize, camelize } from 'xcase';
 
+// src/cli.ts
+import Chalk from "chalk";
+import Sywac from "sywac";
+import * as Gitbeaker from "@gitbeaker/rest";
+import API_MAP from "@gitbeaker/core/map.json" with { type: "json" };
+
+// src/utils.ts
+import { camelize, decamelize, depascalize } from "xcase";
 function param(value) {
   let cleaned = value;
   const exceptions = [

refer to #3591

@jdalrymple jdalrymple added type:technical debt Changes only affect the internal code, improving performance/quality type:bug Changes fix a minor bug and removed type:technical debt Changes only affect the internal code, improving performance/quality labels Aug 14, 2024
@jdalrymple jdalrymple merged commit e3320da into jdalrymple:main Aug 21, 2024
2 checks passed
@jdalrymple jdalrymple added type:technical debt Changes only affect the internal code, improving performance/quality and removed type:bug Changes fix a minor bug labels Aug 21, 2024
@jdalrymple
Copy link
Owner

🚀 PR was released in 40.1.3 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. type:technical debt Changes only affect the internal code, improving performance/quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants