Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use rgba colors that allow to fix transparent selection bug in Chrome #590

Closed
2 tasks done
jcubic opened this issue Jun 23, 2020 · 0 comments
Closed
2 tasks done
Labels
feature low resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jun 23, 2020

I have idea for a new feature for jQuery Terminal

In #586 there was bug with PrismJS text selection, this in fact the problem that hex colors give transparent selection in chrome. Fixing prism will not be possible because all colors use hex and we need rgba(....., 0.99) to fix transparent bug.

The formatting should allow to use colors in rgba and hsl.

ref: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value

also hex can be 4 or 8 hex values (including alpha channel). so It can be 3, 4, 6 or 8 values.

TODO

  • code
  • unit tests
@jcubic jcubic added the feature label Jun 23, 2020
@jcubic jcubic added the low label Jul 4, 2020
jcubic added a commit that referenced this issue Jul 24, 2020
jcubic added a commit that referenced this issue Aug 1, 2020
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Aug 1, 2020
@jcubic jcubic closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature low resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant