Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angle brackets and ampersand with prism formater break Command line #410

Closed
jcubic opened this issue Jul 7, 2018 · 6 comments
Closed

Angle brackets and ampersand with prism formater break Command line #410

jcubic opened this issue Jul 7, 2018 · 6 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jul 7, 2018

Steps to reproduce

Use prism formater and type <, > or &

Demo:

https://codepen.io/jcubic/pen/pKMwLZ?editors=0010
@jcubic jcubic changed the title Angle brackets or ampersand with prism formater break Command line Angle brackets and ampersand with prism formater break Command line Jul 7, 2018
jcubic added a commit that referenced this issue Jul 7, 2018
@jcubic
fix broken < > & with cmd + prism #410
2bbb995
jcubic added a commit that referenced this issue Jul 8, 2018
@jcubic
Fix formatting + prism + add website syntax + add syntax helper #410
204a988
@jcubic
Copy link
Owner Author

jcubic commented Jul 8, 2018

Released in version 1.18.0

@jcubic jcubic closed this as completed Jul 8, 2018
@jcubic
Copy link
Owner Author

jcubic commented Jun 19, 2019

New error, old Codepen demo show error for html syntax https://codepen.io/jcubic/pen/MqyvEG

@jcubic jcubic reopened this Jun 19, 2019
@jcubic jcubic added the Bug label Jun 19, 2019
@jcubic
Copy link
Owner Author

jcubic commented Jul 12, 2019

Self Note: Need to add unit test for prism.

jcubic added a commit that referenced this issue Jul 31, 2019
@jcubic
fix escape brackets in Prism #410
8aef5cb
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jul 31, 2019
@jcubic
Copy link
Owner Author

jcubic commented Aug 7, 2019

The problem was that xml and html with Prism is recursive and escape that was added was escaping formatting not only text inside.

@jcubic jcubic closed this as completed Aug 11, 2019
@jcubic
Copy link
Owner Author

jcubic commented Sep 9, 2019

It's still broken, unit tests were not created.

@jcubic jcubic reopened this Sep 9, 2019
jcubic added a commit that referenced this issue Sep 14, 2019
@jcubic
Fix prism with nested formatting like xml #410
17d903f
@jcubic
Copy link
Owner Author

jcubic commented Sep 14, 2019

The issue is fixed, Codepen demo have update embeded prism.js code.

@jcubic jcubic mentioned this issue Sep 14, 2019
Closed
@jcubic jcubic closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic