stop accidental leakage of /dev/null fd to child procs #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a file descriptor leak introduced by previous commit 1d025fb which opens
/dev/null
and duplicates it onto the standard input descriptor so child processes do not inherit the tty where X started as their standard input. This PR is a trivial patch to close the leak.It was noticed like so:
the fd 4 is the one from the
open("/dev/null")
call held by sdorfehs:The patch closes the
/dev/null
after duplicating, so it won't propagate.