[patch] use icu data from prebuild binary #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this merges to the
intl
branch.Use https://github.com/unicode-org/full-icu-npm to grab prebuild binary and pass data to node as runtime rather than prebuild. For some very unclear reason
--with-intl=full-icu --download=all
keeps failing, see image:This will use a runtime feature in node (which already has small-icu) https://nodejs.org/api/intl.html#intl_providing_icu_data_at_runtime. Since
full-icu
will be baked in withnodejs>13
nodejs/node#29522 this alternative 'fix' is good enough for ournode@12
usage.Validation that it works (Spanish for January)