Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] use icu data from prebuild binary #1

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

Swaagie
Copy link

@Swaagie Swaagie commented Feb 21, 2020

Note: this merges to the intl branch.

Use https://github.com/unicode-org/full-icu-npm to grab prebuild binary and pass data to node as runtime rather than prebuild. For some very unclear reason --with-intl=full-icu --download=all keeps failing, see image:

image

This will use a runtime feature in node (which already has small-icu) https://nodejs.org/api/intl.html#intl_providing_icu_data_at_runtime. Since full-icu will be baked in with nodejs>13 nodejs/node#29522 this alternative 'fix' is good enough for our node@12 usage.

Validation that it works (Spanish for January)

image

@msluther msluther merged commit 4740ef8 into jcrugzz:intl Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants