Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Engine] [User Can] Include logos from other files #39

Closed
jcoliz opened this issue Jul 11, 2024 · 1 comment
Closed

[Engine] [User Can] Include logos from other files #39

jcoliz opened this issue Jul 11, 2024 · 1 comment
Labels
enhancement New feature or request P2-Important

Comments

@jcoliz
Copy link
Owner

jcoliz commented Jul 11, 2024

Problem is: I have multiple definitions which draw from the same logos, so I have multiple copies of the same logo definition in multiple files, all of which would need to be updated.

Would be better if I could define all the logos in one file, and then pull them in, e.g.

[files]
include.logos = "other_file.toml"

In this case, the whole file would be loaded as a definition, and all the logos from that file merged in with the logos in the current file.

@jcoliz jcoliz added the enhancement New feature or request label Jul 11, 2024
@jcoliz
Copy link
Owner Author

jcoliz commented Jul 18, 2024

One problem here is that the text width specified in the included file is likely to be wrong in the new file. Current ideas are:

  • Discard text width from included logos, and
  • Allow specifying ONLY the text width in the new file, e.g.
[logos.something]
text_width = 1.4
# title and path taken from included logos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2-Important
Projects
None yet
Development

No branches or pull requests

1 participant