Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add new DateTimeField & DateTimePickerWidget #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[feat] add new DateTimeField & DateTimePickerWidget #22

wants to merge 4 commits into from

Conversation

areski
Copy link

@areski areski commented Jul 21, 2021 •
edited
Loading

Adding a DateTimeField that can be used without range.

Extra change:

  • fix error on jsonify on the datetime
  • add a new common_datetimes

jckw
jckw reviewed Jul 22, 2021
View reviewed changes
Copy link
Owner

@jckw jckw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Just one comment, and I think it would be nice to get an example into the README.

Thanks for putting this together :)

bootstrap_daterangepicker/widgets.py
'DateRangeWidget',
'DateTimeRangeWidget',
'add_month',
'common_dates'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to add 'common_datetimes' here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@areski
Copy link
Author

areski commented Jul 23, 2021

@jckw Done & thanks for the quick follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckw jckw jckw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@areski @jckw